<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">unistd.h is not part of C - it is for Unix and Unix-like systems. There is a test for this file in configure.ac that should be used, and the Unixism in the test should be removed or protected. The test programs should not assume Unix/POSIX/Linux. The other fixes look good.<div><br></div><div>Bill</div><div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div style="font-size: 12px; ">William Gropp</div><div style="font-size: 12px; ">Director, Parallel Computing Institute</div><div style="font-size: 12px; ">Deputy Director for Research</div><div style="font-size: 12px; ">Institute for Advanced Computing Applications and Technologies</div></div></div></span><span class="Apple-style-span" style="font-size: 12px; ">Thomas M. Siebel Chair in Computer Science</span><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div style="font-size: 12px; ">University of Illinois Urbana-Champaign</div></div><div><br></div></div></span><br class="Apple-interchange-newline"></span><br class="Apple-interchange-newline">
</div>
<br><div><div>On Feb 18, 2013, at 6:47 AM, Jeff Hammond wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>I'm submitting this via email because Trac is hosed right now (I<br>assume it will be fixed in a few hours, but I don't want to enqueue<br>this in my head that long).<br><br>LLVM complained about use of undeclared functions being invalid in<br>C99. I fixed them in the attached patch, which is copied below.<br><br>The fix to test/mpi/rma/mutex_bench.c depends upon the patch to<br>test/mpi/rma/Makefile.am because otherwise the header will not be<br>found.<br><br>Best,<br><br>Jeff<br><br>$ cat test.patch<br>diff --git a/test/mpi/coll/nonblocking3.c b/test/mpi/coll/nonblocking3.c<br>index b1f66dd..8e896b7 100644<br>--- a/test/mpi/coll/nonblocking3.c<br>+++ b/test/mpi/coll/nonblocking3.c<br>@@ -16,6 +16,7 @@<br> #include "mpi.h"<br> #include <stdlib.h><br> #include <stdio.h><br>+#include <unistd.h><br> #include <string.h><br> #include <assert.h><br> /* USE_STRICT_MPI may be defined in mpitestconf.h */<br>diff --git a/test/mpi/f90/attr/attrlangc.c b/test/mpi/f90/attr/attrlangc.c<br>index 6920668..2ee4ef5 100644<br>--- a/test/mpi/f90/attr/attrlangc.c<br>+++ b/test/mpi/f90/attr/attrlangc.c<br>@@ -124,7 +124,7 @@ void cgetsizes_( MPI_Fint *ptrSize, MPI_Fint<br>*intSize, MPI_Fint *aintSize )<br> }<br><br> /* ----------------------------------------------------------------------- */<br>-/* Copy and delete functions attached to keyvals<br>+/* Copy and delete functions attached to keyvals */<br> /* ----------------------------------------------------------------------- */<br> static int CMPI1_COPY_FN( MPI_Comm comm, int keyval, void *extra,<br> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> void *inval, void *outval, int *flag )<br>diff --git a/test/mpi/manual/mpi_t/nem_fbox_fallback_to_queue_count.c<br>b/test/mpi/manual/mpi_t/nem_fbox_fallback_to_queue_count.c<br>index f045212..9718bbc 100644<br>--- a/test/mpi/manual/mpi_t/nem_fbox_fallback_to_queue_count.c<br>+++ b/test/mpi/manual/mpi_t/nem_fbox_fallback_to_queue_count.c<br>@@ -17,6 +17,7 @@<br> #include <stdlib.h><br> #include <stdint.h><br> #include <stdio.h><br>+#include <unistd.h><br><br> #define TRY(func) \<br> do { \<br>diff --git a/test/mpi/rma/Makefile.am b/test/mpi/rma/Makefile.am<br>index 579721a..76155c5 100644<br>--- a/test/mpi/rma/Makefile.am<br>+++ b/test/mpi/rma/Makefile.am<br>@@ -155,5 +155,5 @@ get_accumulate_double_derived_SOURCES = get_accumulate.c<br> get_accumulate_int_derived_SOURCES = get_accumulate.c<br><br> mutex_bench_SOURCES = mutex_bench.c mcs-mutex.c mcs-mutex.h<br>-mutex_bench_shared_CPPFLAGS = -DUSE_WIN_SHARED<br>+mutex_bench_shared_CPPFLAGS = -DUSE_WIN_SHARED $(AM_CPPFLAGS)<br> mutex_bench_shared_SOURCES = mutex_bench.c mcs-mutex.c mcs-mutex.h<br>diff --git a/test/mpi/rma/lockcontention3.c b/test/mpi/rma/lockcontention3.c<br>index 6204e94..196dfb5 100644<br>--- a/test/mpi/rma/lockcontention3.c<br>+++ b/test/mpi/rma/lockcontention3.c<br>@@ -8,6 +8,7 @@<br> #include "stdlib.h"<br> #include "mpitest.h"<br> #include <assert.h><br>+#include <string.h><br><br> #define LAST_TEST 14<br> #define RMA_SIZE 2048<br>diff --git a/test/mpi/rma/mutex_bench.c b/test/mpi/rma/mutex_bench.c<br>index 098382e..2db24e4 100644<br>--- a/test/mpi/rma/mutex_bench.c<br>+++ b/test/mpi/rma/mutex_bench.c<br>@@ -12,6 +12,7 @@<br> #include <assert.h><br><br> #include <mpi.h><br>+#include "mpitest.h"<br> #include "mcs-mutex.h"<br><br> #define NUM_ITER 1000<br><br>-- <br>Jeff Hammond<br>Argonne Leadership Computing Facility<br>University of Chicago Computation Institute<br><a href="mailto:jhammond@alcf.anl.gov">jhammond@alcf.anl.gov</a> / (630) 252-5381<br><a href="http://www.linkedin.com/in/jeffhammond">http://www.linkedin.com/in/jeffhammond</a><br>https://wiki.alcf.anl.gov/parts/index.php/User:Jhammond<br><span><test.patch></span></div></blockquote></div><br></div></body></html>