[mpich-commits] r10793 - mpich2/trunk/src/pm/hydra/pm/pmiserv

[balaji at mcs.anl.gov]

Author: balaji
Date: 2012-12-19 23:55:27 -0600 (Wed, 19 Dec 2012)
New Revision: 10793

Modified:
   mpich2/trunk/src/pm/hydra/pm/pmiserv/pmip_cb.c
Log:
We were not checking if the downstream stdin socket was valid before
setting it to nonblocking.  We released 3.0 without this fix.  God
help us with the bug reports!

No reviewer.

Modified: mpich2/trunk/src/pm/hydra/pm/pmiserv/pmip_cb.c
===================================================================
--- mpich2/trunk/src/pm/hydra/pm/pmiserv/pmip_cb.c	2012-12-20 05:32:54 UTC (rev 10792)
+++ mpich2/trunk/src/pm/hydra/pm/pmiserv/pmip_cb.c	2012-12-20 05:55:27 UTC (rev 10793)
@@ -704,8 +704,10 @@
                                          process_id);
             HYDU_ERR_POP(status, "create process returned error\n");
 
-            status = HYDU_sock_set_nonblock(HYD_pmcd_pmip.downstream.in);
-            HYDU_ERR_POP(status, "unable to set stdin socket to non-blocking\n");
+            if (HYD_pmcd_pmip.downstream.in != HYD_FD_UNSET) {
+                status = HYDU_sock_set_nonblock(HYD_pmcd_pmip.downstream.in);
+                HYDU_ERR_POP(status, "unable to set stdin socket to non-blocking\n");
+            }
 
             HYDU_free_strlist(client_args);