[mpich-commits] r10699 - mpich2/trunk/src/pm/hydra/tools/demux

[balaji at mcs.anl.gov]

Author: balaji
Date: 2012-11-30 01:49:00 -0600 (Fri, 30 Nov 2012)
New Revision: 10699

Modified:
   mpich2/trunk/src/pm/hydra/tools/demux/demux.c
Log:
Improve the check for a valid stdin.

No reviewer.

Modified: mpich2/trunk/src/pm/hydra/tools/demux/demux.c
===================================================================
--- mpich2/trunk/src/pm/hydra/tools/demux/demux.c	2012-11-30 07:48:57 UTC (rev 10698)
+++ mpich2/trunk/src/pm/hydra/tools/demux/demux.c	2012-11-30 07:49:00 UTC (rev 10699)
@@ -235,19 +235,7 @@
     }
 #endif /* SIGTTIN and HAVE_ISATTY */
 
-    /* FIXME: The below read() check for STDIN validity is somehow
-     * interfering in the case where the application is run in the
-     * background, but expects some STDIN. The correct behavior is to
-     * close the STDIN socket for the application in that
-     * case. However, this seems to hang. I'm still investigating this
-     * case. In the meanwhile, I have commented out this check. PLEASE
-     * DO NOT DELETE. All other cases dealing with STDIN seem to be
-     * working correctly. */
-#if 0
     ret = read(STDIN_FILENO, NULL, 0);
-#else
-    ret = 0;
-#endif
     if (ret < 0 && errno == EINTR && got_sigttin)
         *out = 0;
     else