[mpich-commits] [mpich] MPICH primary repository branch, master, updated. v3.0.3-43-gfbc0709
mysql vizuser
noreply at mpich.org
Mon Apr 22 20:57:21 CDT 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "MPICH primary repository".
The branch, master has been updated
via fbc070994cc58f713ecb206721da42b9d8c95dcb (commit)
via 1a95a84b7a83c1920da1264817aa96c6d0fb8f64 (commit)
via 163170510458a9921dfd0bdfdc8255746a73704f (commit)
from fd583f48d7e8b3009e359c35786a8fc0f9cc398c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://git.mpich.org/mpich.git/commitdiff/fbc070994cc58f713ecb206721da42b9d8c95dcb
commit fbc070994cc58f713ecb206721da42b9d8c95dcb
Author: Pavan Balaji <balaji at mcs.anl.gov>
Date: Mon Apr 22 14:45:36 2013 -0500
Make the InitPG naming consistent.
Avoid camel-cased names.
Reviewed by goodell.
diff --git a/src/mpid/ch3/src/mpid_init.c b/src/mpid/ch3/src/mpid_init.c
index c37014b..414734f 100644
--- a/src/mpid/ch3/src/mpid_init.c
+++ b/src/mpid/ch3/src/mpid_init.c
@@ -30,7 +30,7 @@ char *MPIDI_DBG_parent_str = "?";
int MPIDI_Use_pmi2_api = 0;
-static int InitPG( int *argc_p, char ***argv_p,
+static int init_pg( int *argc_p, char ***argv_p,
int *has_args, int *has_env, int *has_parent,
int *pg_rank_p, MPIDI_PG_t **pg_p );
static int pg_compare_ids(void * id1, void * id2);
@@ -133,7 +133,7 @@ int MPID_Init(int *argc, char ***argv, int requested, int *provided,
/*
* Perform channel-independent PMI initialization
*/
- mpi_errno = InitPG( argc, argv,
+ mpi_errno = init_pg( argc, argv,
has_args, has_env, &has_parent, &pg_rank, &pg );
if (mpi_errno) {
MPIU_ERR_SETANDJUMP(mpi_errno,MPI_ERR_OTHER, "**ch3|ch3_init");
@@ -352,7 +352,7 @@ int MPID_InitCompleted( void )
* process group structures.
*
*/
-static int InitPG( int *argc, char ***argv,
+static int init_pg( int *argc, char ***argv,
int *has_args, int *has_env, int *has_parent,
int *pg_rank_p, MPIDI_PG_t **pg_p )
{
http://git.mpich.org/mpich.git/commitdiff/1a95a84b7a83c1920da1264817aa96c6d0fb8f64
commit 1a95a84b7a83c1920da1264817aa96c6d0fb8f64
Author: Pavan Balaji <balaji at mcs.anl.gov>
Date: Mon Apr 22 14:44:47 2013 -0500
Static functions do not need to be name-spaced.
Reviewed by goodell.
diff --git a/src/mpid/ch3/src/mpid_init.c b/src/mpid/ch3/src/mpid_init.c
index 8d0e748..c37014b 100644
--- a/src/mpid/ch3/src/mpid_init.c
+++ b/src/mpid/ch3/src/mpid_init.c
@@ -33,9 +33,9 @@ int MPIDI_Use_pmi2_api = 0;
static int InitPG( int *argc_p, char ***argv_p,
int *has_args, int *has_env, int *has_parent,
int *pg_rank_p, MPIDI_PG_t **pg_p );
-static int MPIDI_CH3I_PG_Compare_ids(void * id1, void * id2);
-static int MPIDI_CH3I_PG_Destroy(MPIDI_PG_t * pg );
-static int MPIDI_CH3_Set_eager_threshold(MPID_Comm *comm_ptr, MPID_Info *info, void *state);
+static int pg_compare_ids(void * id1, void * id2);
+static int pg_destroy(MPIDI_PG_t * pg );
+static int set_eager_threshold(MPID_Comm *comm_ptr, MPID_Info *info, void *state);
MPIDI_Process_t MPIDI_Process = { NULL };
MPIDI_CH3U_SRBuf_element_t * MPIDI_CH3U_SRBuf_pool = NULL;
@@ -59,10 +59,10 @@ static int finalize_failed_procs_group(void *param)
}
#undef FUNCNAME
-#define FUNCNAME MPIDI_CH3_Set_eager_threshold
+#define FUNCNAME set_eager_threshold
#undef FCNAME
#define FCNAME MPIU_QUOTE(FUNCNAME)
-static int MPIDI_CH3_Set_eager_threshold(MPID_Comm *comm_ptr, MPID_Info *info, void *state)
+static int set_eager_threshold(MPID_Comm *comm_ptr, MPID_Info *info, void *state)
{
int mpi_errno = MPI_SUCCESS;
char *endptr;
@@ -323,7 +323,7 @@ int MPID_Init(int *argc, char ***argv, int requested, int *provided,
}
mpi_errno = MPIR_Comm_register_hint("eager_rendezvous_threshold",
- MPIDI_CH3_Set_eager_threshold,
+ set_eager_threshold,
NULL);
if (mpi_errno) MPIU_ERR_POP(mpi_errno);
@@ -482,7 +482,7 @@ static int InitPG( int *argc, char ***argv,
* Initialize the process group tracking subsystem
*/
mpi_errno = MPIDI_PG_Init(argc, argv,
- MPIDI_CH3I_PG_Compare_ids, MPIDI_CH3I_PG_Destroy);
+ pg_compare_ids, pg_destroy);
if (mpi_errno != MPI_SUCCESS) {
MPIU_ERR_SETANDJUMP(mpi_errno,MPI_ERR_OTHER,"**dev|pg_init");
}
@@ -582,13 +582,13 @@ int MPIDI_CH3I_BCFree( char *bc_val )
/* FIXME: The PG code should supply these, since it knows how the
pg_ids and other data are represented */
-static int MPIDI_CH3I_PG_Compare_ids(void * id1, void * id2)
+static int pg_compare_ids(void * id1, void * id2)
{
return (strcmp((char *) id1, (char *) id2) == 0) ? TRUE : FALSE;
}
-static int MPIDI_CH3I_PG_Destroy(MPIDI_PG_t * pg)
+static int pg_destroy(MPIDI_PG_t * pg)
{
if (pg->id != NULL)
{
http://git.mpich.org/mpich.git/commitdiff/163170510458a9921dfd0bdfdc8255746a73704f
commit 163170510458a9921dfd0bdfdc8255746a73704f
Author: Pavan Balaji <balaji at mcs.anl.gov>
Date: Mon Apr 22 14:43:03 2013 -0500
Squash warnings.
Reviewed by goodell.
diff --git a/src/mpi/comm/comm_set_info.c b/src/mpi/comm/comm_set_info.c
index 71445c0..5afbc61 100644
--- a/src/mpi/comm/comm_set_info.c
+++ b/src/mpi/comm/comm_set_info.c
@@ -32,7 +32,6 @@
int MPIR_Comm_set_info_impl(MPID_Comm * comm_ptr, MPID_Info * info_ptr)
{
int mpi_errno = MPI_SUCCESS;
- MPID_Info *info;
MPID_Info *curr_info = NULL;
MPID_MPI_STATE_DECL(MPID_STATE_MPIR_COMM_SET_INFO_IMPL);
diff --git a/src/mpid/ch3/src/mpid_init.c b/src/mpid/ch3/src/mpid_init.c
index 2a7b24e..8d0e748 100644
--- a/src/mpid/ch3/src/mpid_init.c
+++ b/src/mpid/ch3/src/mpid_init.c
@@ -35,7 +35,7 @@ static int InitPG( int *argc_p, char ***argv_p,
int *pg_rank_p, MPIDI_PG_t **pg_p );
static int MPIDI_CH3I_PG_Compare_ids(void * id1, void * id2);
static int MPIDI_CH3I_PG_Destroy(MPIDI_PG_t * pg );
-
+static int MPIDI_CH3_Set_eager_threshold(MPID_Comm *comm_ptr, MPID_Info *info, void *state);
MPIDI_Process_t MPIDI_Process = { NULL };
MPIDI_CH3U_SRBuf_element_t * MPIDI_CH3U_SRBuf_pool = NULL;
@@ -62,7 +62,7 @@ static int finalize_failed_procs_group(void *param)
#define FUNCNAME MPIDI_CH3_Set_eager_threshold
#undef FCNAME
#define FCNAME MPIU_QUOTE(FUNCNAME)
-int MPIDI_CH3_Set_eager_threshold(MPID_Comm *comm_ptr, MPID_Info *info, void *state)
+static int MPIDI_CH3_Set_eager_threshold(MPID_Comm *comm_ptr, MPID_Info *info, void *state)
{
int mpi_errno = MPI_SUCCESS;
char *endptr;
-----------------------------------------------------------------------
Summary of changes:
src/mpi/comm/comm_set_info.c | 1 -
src/mpid/ch3/src/mpid_init.c | 24 ++++++++++++------------
2 files changed, 12 insertions(+), 13 deletions(-)
hooks/post-receive
--
MPICH primary repository
More information about the commits
mailing list