[mpich-commits] [mpich] MPICH primary repository branch, master, updated. v3.0.4-411-g27f6340

mysql vizuser noreply at mpich.org
Wed Jul 31 13:11:45 CDT 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "MPICH primary repository".

The branch, master has been updated
       via  27f6340573fe2e7bc0f2a387ab791fa95ec1479d (commit)
      from  b54d7e0831d6f617c3971e05b643a47d06413423 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 27f6340573fe2e7bc0f2a387ab791fa95ec1479d
Author: Pavan Balaji <balaji at mcs.anl.gov>
Date:   Wed Jul 31 10:51:54 2013 -0500

    Error in the buffer attached to dynamic windows.
    In MPICH, Win_attach/detach are essentially no-ops.  The actual
    accumulate calls don't actually check if the actual buffer is attached
    or not.  This is technically a user error.  The win_dynamic_acc test
    had a wrong buffer attached, but was still passing because of this
    reason.  This patch only corrects the test program.
    Thanks to Michael Raymond @ SGI for reporting the error.
    Signed-off-by: Xin Zhao <xinzhao3 at illinois.edu>

diff --git a/test/mpi/rma/win_dynamic_acc.c b/test/mpi/rma/win_dynamic_acc.c
index ebb0a35..ee9f725 100644
--- a/test/mpi/rma/win_dynamic_acc.c
+++ b/test/mpi/rma/win_dynamic_acc.c
@@ -34,7 +34,7 @@ int main(int argc, char **argv) {
     MPI_Win_create_dynamic(MPI_INFO_NULL, MPI_COMM_WORLD, &dyn_win);
-    MPI_Win_attach(dyn_win, &one, sizeof(int));
+    MPI_Win_attach(dyn_win, &val, sizeof(int));
     for (i = 0; i < ITER; i++) {
             MPI_Win_fence(MPI_MODE_NOPRECEDE, dyn_win);
@@ -50,7 +50,7 @@ int main(int argc, char **argv) {
         printf("%d -- Got %d, expected %d\n", rank, val, ITER);
-    MPI_Win_detach(dyn_win, &one);
+    MPI_Win_detach(dyn_win, &val);
     MPI_Reduce(&errors, &all_errors, 1, MPI_INT, MPI_SUM, 0, MPI_COMM_WORLD);


Summary of changes:
 test/mpi/rma/win_dynamic_acc.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

MPICH primary repository

More information about the commits mailing list