[mpich-commits] [mpich] MPICH primary repository branch, master, updated. v3.1b1-173-g1d565e4

mysql vizuser noreply at mpich.org
Thu Oct 31 22:58:45 CDT 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "MPICH primary repository".

The branch, master has been updated
       via  1d565e423860d7aa246e556c4226bee12a0e970d (commit)
       via  62be3f0b7da45519861212a2a1b2a2a3b9423f58 (commit)
      from  eb8baaba906b19260886b95b23ae1435340beedd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.mpich.org/mpich.git/commitdiff/1d565e423860d7aa246e556c4226bee12a0e970d

commit 1d565e423860d7aa246e556c4226bee12a0e970d
Author: Junchao Zhang <jczhang at mcs.anl.gov>
Date:   Wed Oct 30 09:17:23 2013 -0500

    Correct the cvars names and delete unnessary init
    
    Signed-off-by: Pavan Balaji <balaji at mcs.anl.gov>

diff --git a/test/mpi/impls/mpich/mpi_t/collparmt.c b/test/mpi/impls/mpich/mpi_t/collparmt.c
index bb698b1..e691291 100644
--- a/test/mpi/impls/mpich/mpi_t/collparmt.c
+++ b/test/mpi/impls/mpich/mpi_t/collparmt.c
@@ -17,9 +17,9 @@ int main( int argc, char *argv[] )
     MPI_Datatype dtype;
     MPI_T_enum   enumtype;
     MPI_T_cvar_handle bcastHandle, bcastLongHandle;
-    int          bcastCount, bcastScope=MPIX_T_SCOPE_INVALID, bcastCvar=-1;
+    int          bcastCount, bcastScope, bcastCvar=-1;
     int          bcastLongCount, bcastLongScope, bcastLongCvar=-1;
-    int          gatherScope, gatherCvar;
+    int          gatherScope, gatherCvar=-1;
     int          newval;
     int          errs = 0;
 
@@ -35,29 +35,29 @@ int main( int argc, char *argv[] )
 	cnameLen = sizeof(cname);
 	MPI_T_cvar_get_info( i, cname, &cnameLen, &verbosity, &dtype,
 			     &enumtype, NULL, NULL, &binding, &scope );
-	if (strcmp( cname, "GATHER_VSMALL_MSG_SIZE" ) == 0) {
+	if (strcmp( cname, "MPIR_CVAR_GATHER_VSMALL_MSG_SIZE" ) == 0) {
 	    gatherCvar  = i;
 	    gatherScope = scope;
 	}
-	else if (strcmp( cname, "BCAST_SHORT_MSG_SIZE" ) == 0) {
+	else if (strcmp( cname, "MPIR_CVAR_BCAST_SHORT_MSG_SIZE" ) == 0) {
 	    bcastCvar = i;
 	    bcastScope = scope;
 	    if (binding != MPI_T_BIND_NO_OBJECT &&
 		binding != MPI_T_BIND_MPI_COMM) {
-		fprintf( stderr, "Unexpected binding for BCAST_SHORT_MSG\n" );
+		fprintf( stderr, "Unexpected binding for MPIR_CVAR_BCAST_SHORT_MSG\n" );
 		errs++;
 	    }
 	}
-	else if (strcmp( cname, "BCAST_LONG_MSG_SIZE" ) == 0) {
+	else if (strcmp( cname, "MPIR_CVAR_BCAST_LONG_MSG_SIZE" ) == 0) {
 	    bcastLongCvar = i;
 	    bcastLongScope = scope;
 	    if (binding != MPI_T_BIND_NO_OBJECT &&
 		binding != MPI_T_BIND_MPI_COMM) {
-		fprintf( stderr, "Unexpected binding for BCAST_LONG_MSG\n" );
+		fprintf( stderr, "Unexpected binding for MPIR_CVAR_BCAST_LONG_MSG\n" );
 		errs++;
 	    }
 	}
-	else if (strcmp( cname, "BCAST_MIN_PROCS" ) == 0) {
+	else if (strcmp( cname, "MPIR_CVAR_BCAST_MIN_PROCS" ) == 0) {
 	}
     }
 

http://git.mpich.org/mpich.git/commitdiff/62be3f0b7da45519861212a2a1b2a2a3b9423f58

commit 62be3f0b7da45519861212a2a1b2a2a3b9423f58
Author: Rob Latham <robl at mcs.anl.gov>
Date:   Mon Oct 28 13:13:50 2013 -0500

    fix MPI_T test failure due to uninit variables
    
    buildbot reports some crazy error messages:
    INTERNAL ERROR: invalid error code 3e (Ring ids do not match) in PMPI_T_cvar_handle_alloc:135
    
    valgrind more helpfully points out places where uninitialized varables
    were being passed into the MPI_T interface.  Perhaps MPI_T interface
    needs to be robust-ified against garbage inputs?
    
    Signed-off-by: Pavan Balaji <balaji at mcs.anl.gov>

diff --git a/test/mpi/impls/mpich/mpi_t/collparmt.c b/test/mpi/impls/mpich/mpi_t/collparmt.c
index 4f3b7e9..bb698b1 100644
--- a/test/mpi/impls/mpich/mpi_t/collparmt.c
+++ b/test/mpi/impls/mpich/mpi_t/collparmt.c
@@ -17,9 +17,9 @@ int main( int argc, char *argv[] )
     MPI_Datatype dtype;
     MPI_T_enum   enumtype;
     MPI_T_cvar_handle bcastHandle, bcastLongHandle;
-    int          bcastCount, bcastScope, bcastCvar;
-    int          bcastLongCount, bcastLongScope, bcastLongCvar;
-    int          gatherCount, gatherScope, gatherCvar;
+    int          bcastCount, bcastScope=MPIX_T_SCOPE_INVALID, bcastCvar=-1;
+    int          bcastLongCount, bcastLongScope, bcastLongCvar=-1;
+    int          gatherScope, gatherCvar;
     int          newval;
     int          errs = 0;
 

-----------------------------------------------------------------------

Summary of changes:
 test/mpi/impls/mpich/mpi_t/collparmt.c |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
MPICH primary repository


More information about the commits mailing list