[mpich-commits] [mpich] MPICH primary repository branch, master, updated. v3.1-192-ga008397

Service Account noreply at mpich.org
Tue Apr 29 15:25:49 CDT 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "MPICH primary repository".

The branch, master has been updated
       via  a00839739260055c6d2373f41e2a0c53abf679d1 (commit)
      from  172968b2ed596d5ccd444ea10b9bead5104ef7bf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit a00839739260055c6d2373f41e2a0c53abf679d1
Author: Su Huang <suhuang at us.ibm.com>
Date:   Tue Apr 29 08:49:51 2014 -0400

    pamid: datatype is not freed in MPID_Win_accumulate
    In MPID_Win_accumulate, when processing non-contiguous datatype
    for origin, the ref_count of datatype is incremented by one which
    prevents the space allocated for contents and datatloop from being freed.
    In the routine, the data is processed by MPIR_Localcopy and no need to
    increment the reference count (ref_count) of the object by 1.
    Signed-off-by: Michael Blocksome <blocksom at us.ibm.com>

diff --git a/src/mpid/pamid/src/onesided/mpid_win_accumulate.c b/src/mpid/pamid/src/onesided/mpid_win_accumulate.c
index 6ee57d2..714852f 100644
--- a/src/mpid/pamid/src/onesided/mpid_win_accumulate.c
+++ b/src/mpid/pamid/src/onesided/mpid_win_accumulate.c
@@ -270,7 +270,6 @@ MPID_Accumulate(const void   *origin_addr,
       req->buffer_free = 1;
       req->buffer      = MPIU_Malloc(req->origin.dt.size);
       MPID_assert(req->buffer != NULL);
-      MPID_Datatype_add_ref(req->origin.dt.pointer);
       int mpi_errno = 0;
       mpi_errno = MPIR_Localcopy(origin_addr,


Summary of changes:
 src/mpid/pamid/src/onesided/mpid_win_accumulate.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

MPICH primary repository

More information about the commits mailing list