[mpich-commits] [mpich] MPICH primary repository branch, master, updated. v3.1-60-g055abbd

[Service Account]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "MPICH primary repository".

The branch, master has been updated
       via  055abbd3fe7d0239611dd7f70c508a4a546c63aa (commit)
      from  1b0cd5fc5bce6bc9a0b6bde6d8779043b377fd34 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.mpich.org/mpich.git/commitdiff/055abbd3fe7d0239611dd7f70c508a4a546c63aa

commit 055abbd3fe7d0239611dd7f70c508a4a546c63aa
Author: Wesley Bland <wbland at mcs.anl.gov>
Date:   Wed Mar 19 16:13:59 2014 -0500

    Remove the use of MPIDI_TAG_UB
    
    The constant MPIDI_TAG_UB is used in only one place at the moment, in the
    initialization of ch3 (source:src/mpid/ch3/src/mpid_init.c at 4b35902a#L131). The
    problem is that the value which is being set (MPIR_Process.attrs.tag_ub) is
    set differently in pamid (INT_MAX). This leads to weird results when we set
    apart a bit in the tag space for failure propagation in non-blocking
    collectives (see #2008).
    
    Since this value isn't being referenced anywhere else, there doesn't seem to
    be a use for it and it's just leading to confusion. To avoid this, here we
    remove this value and just set MPIR_Process.attrs.tag_ub to INT_MAX in both
    ch3 and pamid.
    
    See #2009
    
    Signed-off-by: Pavan Balaji <balaji at mcs.anl.gov>

diff --git a/src/mpid/ch3/include/mpidpre.h b/src/mpid/ch3/include/mpidpre.h
index 4dc4c6e..8ccbc1b 100644
--- a/src/mpid/ch3/include/mpidpre.h
+++ b/src/mpid/ch3/include/mpidpre.h
@@ -112,11 +112,6 @@ typedef union {
     MPIDI_Message_match_parts_t parts;
     MPIR_Upint whole;
 } MPIDI_Message_match;
-/* NOTE-T1: We set MPIR_Process.attrs.tag_ub to this value during MPID_Init, but
- * upper level code may then modify this value after MPID_Init and before the
- * end of MPIR_Init_thread.  Don't use this value directly, always check the
- * runtime global value. */
-#define MPIDI_TAG_UB (0x7fffffff)
 
 /* Provides MPIDI_CH3_Pkt_t.  Must come after MPIDI_Message_match definition. */
 #include "mpidpkt.h"
diff --git a/src/mpid/ch3/src/mpid_init.c b/src/mpid/ch3/src/mpid_init.c
index e423751..43206bb 100644
--- a/src/mpid/ch3/src/mpid_init.c
+++ b/src/mpid/ch3/src/mpid_init.c
@@ -128,7 +128,7 @@ int MPID_Init(int *argc, char ***argv, int requested, int *provided,
      * Set global process attributes.  These can be overridden by the channel 
      * if necessary.
      */
-    MPIR_Process.attrs.tag_ub = MPIDI_TAG_UB; /* see also mpidpre.h:NOTE-T1 */
+    MPIR_Process.attrs.tag_ub = INT_MAX;
     MPIR_Process.attrs.io = MPI_ANY_SOURCE;
 
     /*

-----------------------------------------------------------------------

Summary of changes:
 src/mpid/ch3/include/mpidpre.h |    5 -----
 src/mpid/ch3/src/mpid_init.c   |    2 +-
 2 files changed, 1 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
MPICH primary repository