[mpich-commits] [mpich] MPICH primary repository branch, master, updated. v3.1-241-gdf15b7f
Service Account
noreply at mpich.org
Fri May 9 17:29:15 CDT 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "MPICH primary repository".
The branch, master has been updated
via df15b7f3d3683d67af651d436b5816ca5f0383e1 (commit)
from 9c4b3bbd6a9c26d76e4e38bbacede668b0e08659 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://git.mpich.org/mpich.git/commitdiff/df15b7f3d3683d67af651d436b5816ca5f0383e1
commit df15b7f3d3683d67af651d436b5816ca5f0383e1
Author: Pavan Balaji <balaji at anl.gov>
Date: Fri May 9 12:37:44 2014 -0500
Fix ibsend failures with the pathscale compilers.
A bunch of arbitrary changes were made to the ibsend.c test in
[85e4a507]. It included using different pthread handles, which is
correct. But the same commit also included: (1) setting a joinable
pthread attribute, (2) using pthread_exit to force kill threads, and
(3) several updates to the documentation. The first change
isunnecessary since it's set by default. The second change is plainly
wrong. pthreads should be cleanly joined, not force killed. The
third change is fine, but should have been a separate commit.
This patch fixes the second change and uses "return NULL" instead of
pthread_exit.
Signed-off-by: Ken Raffenetti <raffenet at mcs.anl.gov>
diff --git a/test/mpi/threads/pt2pt/ibsend.c b/test/mpi/threads/pt2pt/ibsend.c
index 6050c00..1e634c4 100644
--- a/test/mpi/threads/pt2pt/ibsend.c
+++ b/test/mpi/threads/pt2pt/ibsend.c
@@ -43,7 +43,7 @@ void *receiver(void *ptr)
MPI_Recv(buf, MSGSIZE, MPI_CHAR, MPI_ANY_SOURCE, MPI_ANY_TAG,
MPI_COMM_WORLD, MPI_STATUS_IGNORE);
- pthread_exit(NULL);
+ return NULL;
}
@@ -53,7 +53,7 @@ void *sender_bsend(void *ptr)
MPI_Bsend(buffer, MSGSIZE, MPI_CHAR, (rank + 1) % size, 0,
MPI_COMM_WORLD);
- pthread_exit(NULL);
+ return NULL;
}
void *sender_ibsend(void *ptr)
@@ -64,7 +64,7 @@ void *sender_ibsend(void *ptr)
MPI_COMM_WORLD, &req);
MPI_Wait(&req, MPI_STATUS_IGNORE);
- pthread_exit(NULL);
+ return NULL;
}
void *sender_isend(void *ptr)
@@ -75,7 +75,7 @@ void *sender_isend(void *ptr)
MPI_COMM_WORLD, &req);
MPI_Wait(&req, MPI_STATUS_IGNORE);
- pthread_exit(NULL);
+ return NULL;
}
void *sender_send(void *ptr)
@@ -84,7 +84,7 @@ void *sender_send(void *ptr)
MPI_Send(buffer, MSGSIZE, MPI_CHAR, (rank + 1) % size, 0,
MPI_COMM_WORLD);
- pthread_exit(NULL);
+ return NULL;
}
int main(int argc, char *argv[])
-----------------------------------------------------------------------
Summary of changes:
test/mpi/threads/pt2pt/ibsend.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
hooks/post-receive
--
MPICH primary repository
More information about the commits
mailing list