[mpich-commits] [mpich] MPICH primary repository branch, master, updated. v3.2-439-gf41c57b

Service Account noreply at mpich.org
Mon Sep 12 10:19:09 CDT 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "MPICH primary repository".

The branch, master has been updated
       via  f41c57bf9d4961ef3d0f4bb6e0707b6a2394722b (commit)
       via  eafd9b8ba716229b5eed23ad88d4c6602413fc04 (commit)
      from  c8ef14c5e1b49e822b5170b8efcc9154a0907673 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.mpich.org/mpich.git/commitdiff/f41c57bf9d4961ef3d0f4bb6e0707b6a2394722b

commit f41c57bf9d4961ef3d0f4bb6e0707b6a2394722b
Author: Min Si <msi at anl.gov>
Date:   Mon Sep 12 10:10:03 2016 -0500

    Compile warning fix for test rma/get_accumulate.
    
    No reviewer.

diff --git a/test/mpi/rma/get_accumulate.c b/test/mpi/rma/get_accumulate.c
index d81ab37..0ffee69 100644
--- a/test/mpi/rma/get_accumulate.c
+++ b/test/mpi/rma/get_accumulate.c
@@ -39,7 +39,8 @@
 #  define TYPE_MPI TYPE_MPI_BASE
 #endif
 
-void reset_bufs(TYPE_C * win_ptr, TYPE_C * res_ptr, TYPE_C * val_ptr, TYPE_C value, MPI_Win win)
+static void reset_bufs(TYPE_C * win_ptr, TYPE_C * res_ptr, TYPE_C * val_ptr, TYPE_C value,
+                       MPI_Win win)
 {
     int rank, nproc, i;
 

http://git.mpich.org/mpich.git/commitdiff/eafd9b8ba716229b5eed23ad88d4c6602413fc04

commit eafd9b8ba716229b5eed23ad88d4c6602413fc04
Author: Min Si <msi at anl.gov>
Date:   Mon Sep 12 09:18:49 2016 -0500

    Reset result buffer for get_accumulate NO_OP tests.
    
    Get_accumulate with NO_OP tests focus on the value of result buffer,
    thus we should always reset the buffer before start test. In the
    original code of rma/get_accumulate.c, the result buffer is only reset
    for the first NO_OP test, thus the later tests cannot catch error.

diff --git a/test/mpi/rma/get_accumulate.c b/test/mpi/rma/get_accumulate.c
index 142ae38..d81ab37 100644
--- a/test/mpi/rma/get_accumulate.c
+++ b/test/mpi/rma/get_accumulate.c
@@ -305,6 +305,8 @@ int main(int argc, char **argv)
         int j, target = (rank + 1) % nproc;
 
         /* Test: origin_buf = NULL */
+        memset(res_ptr, -1, sizeof(TYPE_C) * nproc * COUNT); /* reset result buffer. */
+
         MPI_Win_lock(MPI_LOCK_EXCLUSIVE, target, 0, win);
         MPI_Get_accumulate(NULL, COUNT, TYPE_MPI, res_ptr, COUNT, TYPE_MPI,
                            target, 0, COUNT, TYPE_MPI, MPI_NO_OP, win);
@@ -319,6 +321,8 @@ int main(int argc, char **argv)
         }
 
         /* Test: origin_buf = NULL, origin_count = 0 */
+        memset(res_ptr, -1, sizeof(TYPE_C) * nproc * COUNT);
+
         MPI_Win_lock(MPI_LOCK_EXCLUSIVE, target, 0, win);
         MPI_Get_accumulate(NULL, 0, TYPE_MPI, res_ptr, COUNT, TYPE_MPI,
                            target, 0, COUNT, TYPE_MPI, MPI_NO_OP, win);
@@ -333,6 +337,8 @@ int main(int argc, char **argv)
         }
 
         /* Test: origin_buf = NULL, origin_count = 0, origin_dtype = NULL */
+        memset(res_ptr, -1, sizeof(TYPE_C) * nproc * COUNT);
+
         MPI_Win_lock(MPI_LOCK_EXCLUSIVE, target, 0, win);
         MPI_Get_accumulate(NULL, 0, MPI_DATATYPE_NULL, res_ptr, COUNT, TYPE_MPI,
                            target, 0, COUNT, TYPE_MPI, MPI_NO_OP, win);
@@ -361,6 +367,8 @@ int main(int argc, char **argv)
         int j, target = rank;
 
         /* Test: origin_buf = NULL */
+        memset(res_ptr, -1, sizeof(TYPE_C) * nproc * COUNT);
+
         MPI_Win_lock(MPI_LOCK_EXCLUSIVE, target, 0, win);
         MPI_Get_accumulate(NULL, COUNT, TYPE_MPI, res_ptr, COUNT, TYPE_MPI,
                            target, 0, COUNT, TYPE_MPI, MPI_NO_OP, win);
@@ -376,6 +384,8 @@ int main(int argc, char **argv)
         }
 
         /* Test: origin_buf = NULL, origin_count = 0 */
+        memset(res_ptr, -1, sizeof(TYPE_C) * nproc * COUNT);
+
         MPI_Win_lock(MPI_LOCK_EXCLUSIVE, target, 0, win);
         MPI_Get_accumulate(NULL, 0, TYPE_MPI, res_ptr, COUNT, TYPE_MPI,
                            target, 0, COUNT, TYPE_MPI, MPI_NO_OP, win);
@@ -391,6 +401,8 @@ int main(int argc, char **argv)
         }
 
         /* Test: origin_buf = NULL, origin_count = 0, origin_dtype = NULL */
+        memset(res_ptr, -1, sizeof(TYPE_C) * nproc * COUNT);
+
         MPI_Win_lock(MPI_LOCK_EXCLUSIVE, target, 0, win);
         MPI_Get_accumulate(NULL, 0, MPI_DATATYPE_NULL, res_ptr, COUNT, TYPE_MPI,
                            target, 0, COUNT, TYPE_MPI, MPI_NO_OP, win);

-----------------------------------------------------------------------

Summary of changes:
 test/mpi/rma/get_accumulate.c |   15 ++++++++++++++-
 1 files changed, 14 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
MPICH primary repository


More information about the commits mailing list