[mpich-devel] Second review on test suite change

[Latham, Robert J.]

Bill and I have been working on some datatype changes.  A few weeks
back, that work broke the MPICH-1 tests run out of cron, so we reverted.
Bill's got a series of patches to introduce the MPICH1 tests into the
mpich tests (getting them into the jenkins reports as well).

I think Jenkins is happy with the patches:
https://jenkins.mpich.org/view/mpich-review/job/mpich-review/660/

but there is one fix that's in the "so simple how could it have ever
worked before" category that i'd like to run by a wider audience:

commit b4c9f88fa1aa6a957d2a1df8d9a33561e1d68ab8
Author: William Gropp <wgropp at illinois.edu>
Date:   Sun Feb 2 22:34:37 2014 -0600

    Fix bug in marking unbuilt tests as failed
    
    The xfail additions to the runtests code had an incorrect test on
xfail
    that caused runtests to stop recording a test that could not be
built
    as failed - thus, the test script would report success for all tests
when
    some tests were not run.
    
    Signed-off-by: Rob Latham <robl at mcs.anl.gov>

diff --git a/test/mpi/runtests.in b/test/mpi/runtests.in
index ad15bb55..91157e94 100644
--- a/test/mpi/runtests.in
+++ b/test/mpi/runtests.in
@@ -492,7 +492,7 @@ sub RunList {
                                    $progEnv, $mpiexecArgs, $xfail );
                }
            }
-           elsif ($xfail ne '') {
+           elsif ($xfail eq '') {
                # We expected to run this program, so failure to build
                # is an error
                $found_error = 1;