[mpich-devel] Second review on test suite change

[Latham, Robert J.]

On Tue, 2014-02-04 at 19:36 +0000, Dave Goodell (dgoodell) wrote:
> On Feb 4, 2014, at 1:06 PM, "Latham, Robert J." <robl at mcs.anl.gov> wrote:
> 
> > but there is one fix that's in the "so simple how could it have ever
> > worked before" category that i'd like to run by a wider audience:
> > 
> > commit b4c9f88fa1aa6a957d2a1df8d9a33561e1d68ab8
> 
> I clearly wrote the code in question, see http://git.mpich.org/mpich.git/commitdiff/4aba817fda95da257258befed3fa34167ee44507.  Sorry for the bug.
> 
> To me the fix looks good.  We probably never noticed the bug before because it's somewhat rare for the MPICH test suite to have build failures when built against the matching version of MPICH itself.  Most failures are run-time issues in that case.
> 

Dave! thanks for parachuting in.  

In this case the test that was failing was a new test.  We wouldn't
expect those to fail either but we're only human...

==rob