[mpich-devel] [mpich-commits] [mpich] MPICH primary repository branch, master, updated. v3.1-22-gde80ec8

[Balaji, Pavan]

On Feb 27, 2014, at 1:32 PM, Dave Goodell (dgoodell) <dgoodell at cisco.com> wrote:

>>    # If the program linked OK, make sure there were no warnings
>> -    if test "$prog_links" = "yes" -a "`cat pac_test.log`" = "" ; then
>> +    if test "$prog_links" = "yes" -a "`diff pac_test1.log pac_test2.log`" = "" ; then
>>       AC_DEFINE([HAVE_MACRO_VA_ARGS],[1],[Define if C99-style variable argument list macro functionality])
>>       AC_MSG_RESULT([yes])
>> +    elif "`diff pac_test1.log pac_test2.log`" = "" ; then
> 
> This is bad shell code.  You probably want "elif test" instead.

Gah.  Yes.  My sh —> bash symlink didn’t catch it.  Thanks.  Should probabyl also do test -z rather than compare with the empty string.

  — Pavan