[mpich-devel] Two issues with MPI_File error handling

[Rob Latham]

On 05/08/2015 04:04 AM, Lisandro Dalcin wrote:
> On 7 May 2015 at 22:00, Rob Latham <robl at mcs.anl.gov> wrote:
>>
>>
>> Thanks for reporting these two issues.  These two patches (attached) address
>> your test case, but it's a part of the code I don't play in often, so I'm
>> going to need a review on them before committing:
>>
>
> Rob, I think you patch 2 is not right. It will endup calling the error
> handler set in COMM_WORLD. So if you set the FATAL errhandler in a
> file, but the RETURNS in comm world, then things will not work as
> expected.
>
> I think a better approach would be to somehow call
>
> handleFatalError(NULL, "MPI_File_call_errhandler", errorcode);
>
> in errutil.c, but that would require some code refactoring to access
> that function.

I've done that refactoring -- possibly not in the most MPICH-y of ways 
-- in the attached patch 0002

==rob

-- 
Rob Latham
Mathematics and Computer Science Division
Argonne National Lab, IL USA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-avoid-segfault-when-calling-built-in-error-handler.patch
Type: text/x-patch
Size: 952 bytes
Desc: not available
URL: <http://lists.mpich.org/pipermail/devel/attachments/20150508/3704c431/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-proper-return-value-for-MPI_File_call_errhandler.patch
Type: text/x-patch
Size: 2632 bytes
Desc: not available
URL: <http://lists.mpich.org/pipermail/devel/attachments/20150508/3704c431/attachment-0001.bin>