[mpich-devel] [PATCH] ofi: need to specify ordering for FI_EP_RDM
raffenet at mcs.anl.gov
Fri Sep 4 14:28:19 CDT 2015
On 09/04/2015 12:27 PM, Jeff Squyres (jsquyres) wrote:
> On Sep 4, 2015, at 12:27 PM, Rob Latham <robl at mcs.anl.gov> wrote:
>> We have a formal workflow for frequent contributors that involves sign-offs and such. For occasional contributions, sending a patch to devel at mpich (as you did) works great.
>> Ken's going to review this.
> This patch is important to us because Cisco's usNIC libfabric support is actual UDP under the covers, hence, if you want ordering (and you really do when you use the tag-matching interface; it doesn't make sense, otherwise), then you need to ask for it.
> Other libfabric interfaces that provide the tag-matching support (e.g., PSM) are inherently ordered already, so even if you didn't ask for it, you got it, and it all worked out ok.
This patch looks correct. I'm just running it through our Jenkins to
sanity check it. A few minor issues.
1. I'd like to omit the whitespace modifications so it's clear that it's
just the 2 lines that were added for this change.
2. Our project uses "Signed-off-by" as an indication of code review.
While we are aware this is contrary to how most git projects work, this
is the current situation. For consistency, I would remove your signoff
and add my own to indicate I reviewed the patch before pushing to
master. Does that sound okay?
More information about the devel