[mpich-devel] [PATCH] ofi: need to specify ordering for FI_EP_RDM

[Jeff Squyres (jsquyres)]

It's the work of 30 seconds, so I'll just resubmit without the signoff and whitespace changes.  You can use my re-submission, or if you've done it locally already, cool.

> On Sep 4, 2015, at 3:31 PM, Jeff Squyres (jsquyres) <jsquyres at cisco.com> wrote:
> 
> On Sep 4, 2015, at 3:28 PM, Kenneth Raffenetti <raffenet at mcs.anl.gov> wrote:
>> 
>> This patch looks correct. I'm just running it through our Jenkins to sanity check it. A few minor issues.
>> 
>> 1. I'd like to omit the whitespace modifications so it's clear that it's just the 2 lines that were added for this change.
> 
> Sure, no problem.  I did it because everything was lined up; it looked like someone did that on purpose, so I just maintained it.  
> 
> Would you like me to re-submit without the whitespace change?  I'm happy to do so.
> 
>> 2. Our project uses "Signed-off-by" as an indication of code review. While we are aware this is contrary to how most git projects work, this is the current situation. For consistency, I would remove your signoff and add my own to indicate I reviewed the patch before pushing to master. Does that sound okay?
> 
> No problem from me.  If you'd like me to re-submit for the whitespace stuff, I can remove my signoff.
> 
> -- 
> Jeff Squyres
> jsquyres at cisco.com
> For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
> 


-- 
Jeff Squyres
jsquyres at cisco.com
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/