[mpich-devel] whitespace cleanup proposal

[Steven Oyanagi]

Hi,

No one is bringing up anything else besides CH3, so just CH3.
	- Steve

-----Original Message-----
From: Wesley Bland <wesley.bland at intel.com>
Reply-To: "devel at mpich.org" <devel at mpich.org>
Date: Tuesday, October 31, 2017 at 11:38 AM
To: "devel at mpich.org" <devel at mpich.org>
Subject: Re: [mpich-devel] whitespace cleanup proposal

>That's fine with me. So are there any other parts you want to blacklist
>from the cleanup script or just everything under src/mpid/ch3?
>
>> On Oct 31, 2017, at 11:36 AM, Steven Oyanagi <sko at cray.com> wrote:
>> 
>> Hi Wesley,
>> 
>> I am one of (and possibly the only) one who suggested that CH3 be left
>> alone.  I agree that the parts that will be changing in the future (mpi,
>> mpid/common, util, etc) do need to be run through the code cleanup
>>script.
>> As you point out, not much new is going into CH3, and for those of us
>>who
>> will need to maintain ch3 for a while yet it would be helpful to not
>>have
>> to do a lot of work there due to code cleanup.
>> 	- Steve
>> 
>> -----Original Message-----
>> From: Wesley Bland <wesley.bland at intel.com>
>> Reply-To: "devel at mpich.org" <devel at mpich.org>
>> Date: Tuesday, October 31, 2017 at 10:16 AM
>> To: "devel at mpich.org" <devel at mpich.org>
>> Subject: Re: [mpich-devel] whitespace cleanup proposal
>> 
>>> I'm fine with leaving CH3 alone (I don't do much development in there),
>>> but it would make this sort of thing a lot less useful if we can't run
>>>it
>>> on all of the other code (mpi, mpid/common, util, etc.). There's still
>>> plenty of work happening there and if we're picking and choosing where
>>> the code cleanup script is run, automated checking gets harder too.
>>> 
>>>> On Oct 31, 2017, at 9:44 AM, Kenneth Raffenetti <raffenet at mcs.anl.gov>
>>>> wrote:
>>>> 
>>>> Hi folks,
>>>> 
>>>> Some devs have expressed a desire to run the maint/code-cleanup.sh
>>>> script across the whole MPICH repo. This would make all whitespace and
>>>> style consistent, and give us the opportunity to use an automated
>>>> checker for new code to ensure it matches the rest of the repo.
>>>> 
>>>> There has been reasonable concern that we not run this on the
>>>> src/mpid/ch3 directory, as it would be too disruptive to downstream
>>>> repos. I think we are in agreement that we will leave ch3 alone, if we
>>>> do this. ch4 is still early enough along that we hope it would be ok
>>>>to
>>>> clean up now.
>>>> 
>>>> Please let us know if you have feedback. We'd like to make a decision
>>>> regarding this prior to the 3.3b1 release at SC17.
>>>> 
>>>> Thanks,
>>>> Ken
>>>> _______________________________________________
>>>> To manage subscription options or unsubscribe:
>>>> https://lists.mpich.org/mailman/listinfo/devel
>>> 
>>> _______________________________________________
>>> To manage subscription options or unsubscribe:
>>> https://lists.mpich.org/mailman/listinfo/devel
>> 
>> _______________________________________________
>> To manage subscription options or unsubscribe:
>> https://lists.mpich.org/mailman/listinfo/devel
>
>_______________________________________________
>To manage subscription options or unsubscribe:
>https://lists.mpich.org/mailman/listinfo/devel