[mpich-discuss] Bugs in Hydra-KVS

[Jan Bierbaum]

Hello!


Doing some experiments with an older version of MPICH I stumbled upon 
two bugs in 'HYD_pmcd_pmi_add_kvs', both of which are still present 
according to Git [1]:

The loop traverses all KVS entries and checks for one with a duplicate 
key. However, it will not check the last entry (Bug 1). When a duplicate 
entry is found the loop is aborted. But the newly created 'key_pair' is 
never freed (Bug 2). I attached a patch that fixes both issues.

Also, newer versions of MPICH do not check anymore whether a duplicate 
KVS entry was encountered - 'HYD_status fn_put' ignores 'ret' completely 
[2] whereas it did some error checking and reporting in older versions. 
This change was introduced in commit 
b98c7fd361541659d7e8fb6ef7fc76547024ad75 [3] and I am not sure whether 
this check was removed intentionally or rather by accident.

Last but not least the README in the release tarball is a bit outdated 
and still refers to the old site, mailing list and SVN repository. I 
attach another patch that updates the file. I also propose to add a link 
to the Git Wiki page [4] directly at the end of the download page [5]. 
It took me quiet a while to realize the repository was publicly available.



Regards, Jan


[1] 
http://git.mpich.org/mpich.git/blob/HEAD:/src/pm/hydra/pm/pmiserv/common.c#l156
[2] 
http://git.mpich.org/mpich.git/blob/HEAD:/src/pm/hydra/pm/pmiserv/pmiserv_pmi_v1.c#l171
[3] 
http://git.mpich.org/mpich.git/commit/b98c7fd361541659d7e8fb6ef7fc76547024ad75
[4] https://wiki.mpich.org/mpich/index.php/Getting_And_Building_MPICH
[5] https://www.mpich.org/downloads/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Hydra-fix-check-for-duplicate-KVS-entries.patch
Type: text/x-patch
Size: 1280 bytes
Desc: not available
URL: <http://lists.mpich.org/pipermail/discuss/attachments/20131014/64ddb686/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Readme-Update-references-to-main-site-mailing-lists-.patch
Type: text/x-patch
Size: 3570 bytes
Desc: not available
URL: <http://lists.mpich.org/pipermail/discuss/attachments/20131014/64ddb686/attachment-0001.bin>