[mpich-discuss] ROMIO filesystem check during MPI_File_open

[Jeff Squyres (jsquyres)]

That seems to do it -- thanks!

Can you send me the git hash when you commit?  When we pull individual patches like this, we like to cite the upstream source where we got it.

Many thanks.


On Mar 24, 2014, at 5:54 PM, Rob Latham <robl at mcs.anl.gov> wrote:

> 
> 
> On 03/24/2014 04:37 PM, Jeff Squyres (jsquyres) wrote:
>> On Mar 24, 2014, at 5:17 PM, Rob Latham <robl at mcs.anl.gov> wrote:
>> 
>>> Every process will call ADIO_FileSysType_fncall() in the case where have_nfs_enabled==1 .  Your interpretation of the code is so different from mine that I'm just going to have to past what I'm looking at and you can tell me where I'm wrong.  These lines come from MPICH's ad_fstype.c.  The content is the same in openmpi-1.6.4, just shifted by 25 or so lines:
>>> 
>>> 637     ADIO_FileSysType_fncall(filename, &file_system, &myerrcode);
>>> 638     if (myerrcode != MPI_SUCCESS) {
>> 
>> This is where our disconnect is occurring: _fncall returns myerrcode==MPI_SUCCESS in all cases.
>> 
>> Meaning: the block with the Allreduce is not entered.  This causes everyone to just use the file_system value they got from _fncall: one will have ADIO_UFS, and the rest will have ADIO_NFS.
>> 
>> /Me checks again just to make sure I'm not goofing this up... Yep: I ran this through DDT and verified that process0 gets file_system==ADIO_UFS/myerrcode==MPI_SUCCESS and process1 gets file_system=ADIO_NFS/myerrcode=MPI_SUCCESS.
>> 
> 
> Thanks, Jeff.  Big help pointing me to the crux of the problem. I don't know why I reduce the error code if it's not successful.  We need to reduce the error code in all cases, and *then* reduce the detected file system type.
> 
> Please try the patch below -- I don't have a mixed NFS/UFS environment I can try this out on.
> 
> ==rob
> 
> 
> 
> 
> -- 
> Rob Latham
> Mathematics and Computer Science Division
> Argonne National Lab, IL USA
> <0001-fix-fs-detection-when-multiple-fs-exist.patch>_______________________________________________
> discuss mailing list     discuss at mpich.org
> To manage subscription options or unsubscribe:
> https://lists.mpich.org/mailman/listinfo/discuss


-- 
Jeff Squyres
jsquyres at cisco.com
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/